[RSS Feed/News] createRedirectionRecordForThread node_id/saveNow arguments are not correctly used

[XenForo]

PHP:

public function createRedirectionRecordForThread(\XF\Entity\Thread $thread, \XF\Entity\Thread $targetThread, $expiryLength = 0, $nodeId = null, $saveNow = true)

createRedirectionRecordForThread doesn't actually do anything with the $nodeId argument;

PHP:

$nodeId = intval($nodeId);
if (!$nodeId)
{
   $thread->node_id;
}

And createRedirectionRecordForThread is incorrectly called inside XF\Service\Thread\Merger::convertSourcesToRedirects as...

Read more

ادامه مطلب...