[RSS Feed/News] Method name \XF\Http\Upload::isValid() is misleading

Status
Not open for further replies.

XenForo

Administrative
  • Thread starter
  • Admin
  • #1
Method name XF\Http\Upload::isValid() indicates that the method is "read only" according to \XF\Util\Php::nameIndicatedReadOnly(), but this is not necessarily the case:

If the uploaded file is an image that needs to be rotated / flipped or resized, caling isValid() internally calls transformImage() which in fact does overwrite the original upload, eg. it does modify data.

Could this be changed so calling isValid() does not modify the...

Read more
Read more about this Feed
 
Status
Not open for further replies.
Back
Top Bottom